----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58977/#review174233 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp Lines 960-968 (patched) <https://reviews.apache.org/r/58977/#comment247345> Hm.. is it possible to make these synchronous? Since these are synchronous accesses to the state, it seems unfortuante to be returning futures here, I can imagine this will be burdensome on the callers. Is it possible at construction time of `Connection` to get this information out of the socket that is passed in and store it within `Data`? That way, we could just read them out synchronously here. - Benjamin Mahler On May 3, 2017, 10:35 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58977/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 10:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7401 > https://issues.apache.org/jira/browse/MESOS-7401 > > > Repository: mesos > > > Description > ------- > > Add local and peer address accessors to http::Connection. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 650b9d8aaba5636e1a445abf9e27e018ff82e610 > 3rdparty/libprocess/src/http.cpp 9789607933745f1fc4e37f47ce1be6aecb33a6e6 > > > Diff: https://reviews.apache.org/r/58977/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
