----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review174461 -----------------------------------------------------------
src/master/http.cpp Line 3647 (original), 3670-3676 (patched) <https://reviews.apache.org/r/58099/#comment247633> As in previous patch, I feel it is better if you do: ```c++ if (approveViewFrameworkInfo(frameworkApprover, framework->info)) { role.add_frameworks()->CopyFrom(frameworkId); } ``` - Alexander Rojas On May 8, 2017, 9:56 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58099/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 9:56 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-7260 > https://issues.apache.org/jira/browse/MESOS-7260 > > > Repository: mesos > > > Description > ------- > > Added authorization for frameworks in `GetRoles` v1 API. > > > Diffs > ----- > > src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31 > > > Diff: https://reviews.apache.org/r/58099/diff/5/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
