> On May 9, 2017, 12:17 a.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > > Lines 48 (patched) > > <https://reviews.apache.org/r/59012/diff/3/?file=1709832#file1709832line48> > > > > no need for a default? > > Gilbert Song wrote: > it does not hurt here. but we should set a default.
Actually it seems to me that no default is more preferable unless necessary (say for backward compatibility). More explicity makes the compiler to catch more bugs :) - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/#review174251 ----------------------------------------------------------- On May 10, 2017, 12:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59012/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 12:47 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing the secret resolver to registry puller. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > b58baed64480e22f640a4852537f85922ed382ae > src/slave/containerizer/mesos/provisioner/appc/store.hpp > 15c79e9401a821e445fbd32b34503e4fb0014d42 > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 09a40a5835454bb7519d11bae4a851337a89b935 > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > ac9dae8ecbb897b8ff942d11ac70281a63e06831 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > 62ddb7a332030f3116477408d8b16c19e434c159 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > src/slave/containerizer/mesos/provisioner/docker/store.hpp > e1abff19c8877ad07900bb2f44deca1cdda41f58 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 7d6c1b93a2c0e265b9344a0fc27f1cf4ed5325f2 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > be45fc59027f176b43b767e9441fd8089ceec7b4 > src/slave/containerizer/mesos/provisioner/store.hpp > 82a9be64264ae829773c1e2e8a4360f78641cbf6 > src/slave/containerizer/mesos/provisioner/store.cpp > 7141d63fcf2dbc3fbf00508c7f92945aab014fb2 > > > Diff: https://reviews.apache.org/r/59012/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
