----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174527 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/puller.hpp Lines 65 (patched) <https://reviews.apache.org/r/59013/#comment247690> Do we need a default value here? It seems that all subclasses need to declare this virtual function anyway. - Chun-Hung Hsiao On May 10, 2017, 12:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59013/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 12:47 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing Image::Secret Puller::pull(). > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 344baab5c0365c3fc2dc814887bb2b48082b050f > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 5bc68d2047a7b3e3fa30315d61073e342ba6affe > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > 62ddb7a332030f3116477408d8b16c19e434c159 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 > src/tests/containerizer/provisioner_docker_tests.cpp > 4341621767a9fa5be2c66e77ef60f0c65dae58ca > > > Diff: https://reviews.apache.org/r/59013/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
