> On May 10, 2017, 8:37 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 239 (patched) > > <https://reviews.apache.org/r/59155/diff/1/?file=1714219#file1714219line244> > > > > What about `STATIC`? All libraries are built with static linkage on > > Windows (at the moment). > > Andrew Schwartzmeyer wrote: > Oh, uh, heh. This `foreach` loop came straight from > [CMake](https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/Platform/Windows-MSVC.cmake#L163). > Checking if `CMAKE_STATIC_LINKER_FLAGS_DEBUG` is the right one to add.
Yup, adding. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59155/#review174547 ----------------------------------------------------------- On May 10, 2017, 8:32 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59155/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 8:32 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Bugs: MESOS-7496 > https://issues.apache.org/jira/browse/MESOS-7496 > > > Repository: mesos > > > Description > ------- > > A previous commit attempted to enable this option, but it was not > actually being used by the linker. This patch correctly adds the option > to each linker flag variable for shared libraries, modules, and > executables, and only for the debug configuration. This results in much > faster link times. > > Also, the `/zc:inline` option was removed, as it is only relevant in > optimized builds (i.e. release configurations). > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a > > > Diff: https://reviews.apache.org/r/59155/diff/1/ > > > Testing > ------- > > Built and tested on Windows with VS Code. > > NOTE: With `/debug:fastlink` properly enabled, the current VS Code C++ > debugger does not work without a manual update. See [this > thread](https://github.com/Microsoft/vscode-cpptools/issues/695#issuecomment-299554289) > for the work-around. > > > Thanks, > > Andrew Schwartzmeyer > >
