----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58904/#review174639 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/composing.cpp Lines 439 (patched) <https://reviews.apache.org/r/58904/#comment247839> YOu can use 'auto' here. - Jie Yu On May 2, 2017, 2:05 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58904/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 2:05 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-7449 > https://issues.apache.org/jira/browse/MESOS-7449 > > > Repository: mesos > > > Description > ------- > > This eliminates one of the entrypoints for launching a container > in the `ComposingContainerizer`. Nested and non-nested containers > are still launched the same way, where nested containers get launched > using their root container's containerizer. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > 8e04bfeb76607e87ee336f4a7f519eac08b7d44c > src/slave/containerizer/composing.cpp > 0b6c76b3d081d86df81a6062ae7a191ba8dadfde > > > Diff: https://reviews.apache.org/r/58904/diff/1/ > > > Testing > ------- > > See last patch in chain. > > > Thanks, > > Joseph Wu > >
