----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/#review174920 -----------------------------------------------------------
Patch looks great! Reviews applied: [59177] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 15, 2017, 1:59 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59177/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 1:59 a.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This new class simplifies the management of the configuration file > given by the user; it loads the TOML file on initialization and > has one method for each element that the user can set. > > This new class and its associated content is also given to the plugins > at initialization so that they can read the user configuration and use > it. > > > Diffs > ----- > > src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da > src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 > src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb > src/cli_new/lib/cli/config.py PRE-CREATION > src/cli_new/lib/cli/plugins/base.py > c10d70fb1b3d232008dd908ea747ec6782a9d47e > src/cli_new/lib/cli/plugins/config/main.py > d95a36f4a66c66b4477c6816b7fa5a721f9212f7 > src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448 > > > Diff: https://reviews.apache.org/r/59177/diff/2/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
