----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59116/#review174987 -----------------------------------------------------------
Ship it! I can fixup the few comments before committing. support/windows-build.bat Line 21 (original), 21 (patched) <https://reviews.apache.org/r/59116/#comment248290> Not sure why, but MSVC 15 changed the path to this script. It is now: ``` /path/to/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat ``` support/windows-build.bat Line 52 (original), 52 (patched) <https://reviews.apache.org/r/59116/#comment248289> As discussed offline, we'll make this default to MSVC 15 (2017). Both the CIs have made the switch already. support/windows-build.bat Lines 87-89 (patched) <https://reviews.apache.org/r/59116/#comment248288> This part is not needed, as (currently) the `mesos-tests` target depends on all other targets being built first. - Joseph Wu On May 10, 2017, 1:40 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59116/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 1:40 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Bugs: MESOS-7343 > https://issues.apache.org/jira/browse/MESOS-7343 > > > Repository: mesos > > > Description > ------- > > It now understands the environment variable `CMAKE_GENERATOR` so that > users can change the generator; the default is still Visual Studio 14. > > Direct usage of `msbuild` was replaced with `cmake --build`. > > We now build `mesos-tests` in the same pattern as `stout-tests` and > `libprocess-tests`. If admin priveleges are missing, we skip running the > tests, but still proceed to build the general target. > > We set the CMake toolset instead of an environment variable for > `PreferredToolArchitecture`. > > > Diffs > ----- > > support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7 > > > Diff: https://reviews.apache.org/r/59116/diff/1/ > > > Testing > ------- > > Built and tested script with clean build on Windows. > > > Thanks, > > Andrew Schwartzmeyer > >
