> On April 19, 2017, 6:28 p.m., Zhitao Li wrote: > > src/java/mesos.pom.in > > Line 86 (original), 86 (patched) > > <https://reviews.apache.org/r/58359/diff/2/?file=1693769#file1693769line86> > > > > This is simply done by a sweeping grep and replace in the code base. > > > > I don't know whether we want to force framework to move to protobuf > > 3.2.0. I guess if the framework author wants to use proto2, they should > > still be able to do it with the same `syntax=proto2` annotation as what > > Mesos does? > > > > I'm fine to keep this out of the current changeset for now, although I > > don't know how compatible protobuf-java at lower version can handle newer > > java classes. > > > > Do we have formal rules about compatibility on released libraries? > > Chun-Hung Hsiao wrote: > This needs to be set to the same version, otherwise maven won't be able > to find the generated `protobuf-java-3.3.1.jar` and will produce `package > com.google.protobuf.GeneratedMessageV3 does not exist` errors. I'm not > familiar with maven so not sure if this can be resolved without restricting > the dependency.
Thanks. So we are going to force framework owners to upgrade to protobuf3 once they upgrade to Mesos 1.4 maven packages. > On April 19, 2017, 6:28 p.m., Zhitao Li wrote: > > src/python/interface/setup.py.in > > Line 29 (original), 29 (patched) > > <https://reviews.apache.org/r/58359/diff/2/?file=1693770#file1693770line29> > > > > Similar to the comment above on java. > > Chun-Hung Hsiao wrote: > The Python unit test works fine without changing the protobuf version > dependency FYI. I still feel that that we should also ask any python framework owners to upgrade to proto3 once they go to Mesos 1.4, but this is not a strong feeling and I'm okay to keep this as old value. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58359/#review172386 ----------------------------------------------------------- On April 18, 2017, 6:25 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58359/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 6:25 p.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > Update Mesos build library to use protobuf 3.2.0. > > > Diffs > ----- > > configure.ac 090783abe98f40c2929ecb4fc025c75936a3d8ef > src/java/mesos.pom.in 080767f011782f048ab0244f93daea189326587c > src/python/interface/setup.py.in 8e38f3feb705f08737cff93e0ed442a1f48dcbf9 > src/python/native_common/ext_modules.py.in > e0bb335e5ae663f398cea904a0e53e3c5fb210d7 > src/python/protocol/setup.py.in b7de10a2a099d21d6eba551ba071b6c31a1460be > support/mesos-tidy/entrypoint.sh 5dbaa6086621934a7313dfa5c8008b6a6f5496f1 > > > Diff: https://reviews.apache.org/r/58359/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
