> On May 15, 2017, 6:42 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/environment_secret.cpp > > Lines 137-138 (patched) > > <https://reviews.apache.org/r/59000/diff/6/?file=1717035#file1717035line137> > > > > How about custom executor/default executor? `task_environment` is for > > command task specific. > > Kapil Arya wrote: > We already set the `launchInfo.environment`; are you suggesting to not > set task_environment?
ah, I see. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review174942 ----------------------------------------------------------- On May 16, 2017, 12:22 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59000/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 12:22 p.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added environment secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt eef718d95b5d8e051a5094369dc9b4532bc307ff > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 > src/slave/containerizer/mesos/containerizer.cpp > 97837c83cc223950750e4cd088f4da067023c96c > src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59000/diff/7/ > > > Testing > ------- > > Added a new test and ran `make check`. > > > Thanks, > > Kapil Arya > >
