> On May 18, 2017, 1:50 p.m., Tim Hansen wrote: > > configure.ac > > Line 346 (original), 346 (patched) > > <https://reviews.apache.org/r/59372/diff/1/?file=1724107#file1724107line346> > > > > This should also be enable_port_mapping_isolator=no
No. The first action is when the flag is specified. So, if the flag is specified, we do want to set it to "yes" after emmitting the warning. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175412 ----------------------------------------------------------- On May 18, 2017, 1:56 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59372/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 1:56 p.m.) > > > Review request for mesos, Jie Yu and Tim Hansen. > > > Repository: mesos > > > Description > ------- > > The corresponding flag (--enable-port-mapping-isolator) was accidentally > enabled by-default in 20dee4190838b5bc7eb9cb524af413e3fe3fe082 > (https://reviews.apache.org/r/59193/). > > > Diffs > ----- > > configure.ac d5236700d2ab06232960f0bed43e8394e9a29aa4 > > > Diff: https://reviews.apache.org/r/59372/diff/2/ > > > Testing > ------- > > Tested the following configurations: > Configure flag Isolator status > `./configure` Disabled > `./configure --with-port-mapping-isolator` Enabled > `./configure --with-network-isolator` Enabled > > > Thanks, > > Kapil Arya > >
