----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59355/#review175463 -----------------------------------------------------------
Patch looks great! Reviews applied: [59383, 59355] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 18, 2017, 10:40 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59355/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 10:40 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-7521 > https://issues.apache.org/jira/browse/MESOS-7521 > > > Repository: mesos > > > Description > ------- > > Rearrange the `children` vector so that inactive leaves are always at > the end of the vector. This makes it easy to skip processing of inactive > leaves. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > fee58d6d1f08163e2a06a4a20c891fe535c3dcff > src/master/allocator/sorter/drf/sorter.cpp > 26b77f578f3235a8792c72d4575d607cdb2c7de7 > > > Diff: https://reviews.apache.org/r/59355/diff/2/ > > > Testing > ------- > > Initial perf testing: > > MESOS 1.2.0: > =================== > ``` > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > Using 5000 agents and 6000 frameworks > Added 6000 frameworks in 90.61248ms > Added 5000 agents in 38.788639509secs > allocate() took 1.030826713secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.051713631secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 932.748778ms to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.150094679secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.052298779secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > (48234 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (48235 ms total) > ``` > > MESOS in master branch: > =================== > ``` > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > Using 5000 agents and 6000 frameworks > Added 6000 frameworks in 295.603058ms > Added 5000 agents in 16.676030553secs > allocate() took 16.258004727secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 16.179602864secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 16.378586621secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 16.394222636secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 16.185625358secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > (102353 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (102353 ms total) > ``` > > MESOS in master branch + this patch: > =================== > ``` > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > Using 5000 agents and 6000 frameworks > Added 6000 frameworks in 312.507943ms > Added 5000 agents in 15.793940251secs > allocate() took 1.170606834secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.128574596secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.03562006secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.229924753secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > allocate() took 1.145860199secs to make 5000 offers with 5940 out of 6000 > frameworks suppressing offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ExtremeSuppressOffers/15 > (25815 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (25819 ms total) > ``` > > > Thanks, > > Neil Conway > >
