> On May 22, 2017, 1:04 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/secret.cpp > > Lines 264 (patched) > > <https://reviews.apache.org/r/59001/diff/9/?file=1721784#file1721784line264> > > > > Do we have to do `force` move?
Yeah, in case the same secret is specified twice in two different volume protos. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review175639 ----------------------------------------------------------- On May 22, 2017, 4:55 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59001/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 4:55 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Added volume secret isolator. > > > Diffs > ----- > > src/CMakeLists.txt a038c0b919cb7ac46c99b37bcfb839217b4ab9b4 > src/Makefile.am 3e71393c4a8e50c9c6f703bbef7f7bdc6a53e6ee > src/slave/containerizer/mesos/containerizer.cpp > 50a63b58b4960729316b0b5685793ce18ee5ce93 > src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION > src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 > src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION > src/tests/containerizer/rootfs.cpp fdfecc65a3fcd19d6a4dfa574320f4d1f2755322 > src/tests/containerizer/volume_secret_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59001/diff/10/ > > > Testing > ------- > > Added new tests an ran `make check`. > > > Thanks, > > Kapil Arya > >
