> On May 22, 2017, 11:32 p.m., Mesos Reviewbot Windows wrote: > > Bad patch! > > > > Reviews applied: [59470] > > > > Failed command: ['cmd', '/c', 'support\\windows-build.bat 2>&1 > > > build_59470'] > > > > Error: > > > > C:\Users\mesos\mesos>REM Licensed to the Apache Software Foundation (ASF) > > under one > > > > C:\Users\mesos\mesos>REM or more contributor license agreements. See the > > NOTICE file > > > > C:\Users\mesos\mesos>REM distributed with this work for additional > > information > > > > C:\Users\mesos\mesos>REM regarding copyright ownership. The ASF licenses > > this file > > > > C:\Users\mesos\mesos>REM to you under the Apache License, Version 2.0 (the > > > > C:\Users\mesos\mesos>REM "License"); you may not use this file except in > > compliance > > > > C:\Users\mesos\mesos>REM with the License. You may obtain a copy of the > > License at > > > > C:\Users\mesos\mesos>REM > > > > C:\Users\mesos\mesos>REM http://www.apache.org/licenses/LICENSE-2.0 > > > > C:\Users\mesos\mesos>REM > > > > C:\Users\mesos\mesos>REM Unless required by applicable law or agreed to in > > writing, software > > > > C:\Users\mesos\mesos>REM distributed under the License is distributed on an > > "AS IS" BASIS, > > > > C:\Users\mesos\mesos>REM WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, > > either express or implied. > > > > C:\Users\mesos\mesos>REM See the License for the specific language > > governing permissions and > > > > C:\Users\mesos\mesos>REM limitations under the License. > > > > C:\Users\mesos\mesos>REM NOTE: Before you run this script, you must have > > the Visual Studio > > > > C:\Users\mesos\mesos>REM environment variables set up. Visual Studio > > provides a script to do this, > > > > C:\Users\mesos\mesos>REM depending on the version of Visual Studio > > installed: > > > > C:\Users\mesos\mesos>REM /path/to/Visual Studio 14/VC/vcvarsall.bat > > > > C:\Users\mesos\mesos>REM /path/to/Microsoft Visual > > Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat > > > > C:\Users\mesos\mesos>REM NOTE: Batch doesn't have any way of exiting upon > > failing a command. > > > > C:\Users\mesos\mesos>REM The best we can do is add this line after every > > command that matters: > > > > C:\Users\mesos\mesos>REM if 0 neq 0 exit /b 0 > > > > C:\Users\mesos\mesos>REM NOTE: In order to run the tests, your Windows > > volume must have a > > > > C:\Users\mesos\mesos>REM folder named `tmp` at the top level. You can > > create it like this: > > > > C:\Users\mesos\mesos>REM MKDIR C:\tmp > > > > C:\Users\mesos\mesos>REM Make sure that we are in the right directory. We > > do this by checking that > > > > C:\Users\mesos\mesos>REM the `support` folder exists in the current > > directory and is not a symlink. > > > > C:\Users\mesos\mesos>REM This code is awkwardly split across two > > conditionals because batch scripts > > > > C:\Users\mesos\mesos>REM do not support logical operators like `&&`. > > > > C:\Users\mesos\mesos>if not exist support (goto not_in_root ) > > > > C:\Users\mesos\mesos>fsutil reparsepoint query "support" | find "Symbolic > > Link" 1>nul && (goto not_in_root ) > > > > C:\Users\mesos\mesos>REM Create a build directory. > > > > C:\Users\mesos\mesos>MKDIR build > > > > C:\Users\mesos\mesos>CD build > > > > C:\Users\mesos\mesos\build>if 0 NEQ 0 exit /b 0 > > > > C:\Users\mesos\mesos\build>REM Generate the Visual Studio solution. > > > > C:\Users\mesos\mesos\build>REM You can pass in other flags by setting > > `OTHER_CMAKE_OPTIONS` before > > > > C:\Users\mesos\mesos\build>REM calling the script. For example, the ASF CI > > will add `-DPATCHEXE_PATH=...` > > > > C:\Users\mesos\mesos\build>REM because the path to GNU Patch is not the > > default. > > > > C:\Users\mesos\mesos\build>if not defined CMAKE_GENERATOR (set > > CMAKE_GENERATOR=Visual Studio 15 2017 Win64 ) > > > > C:\Users\mesos\mesos\build>cmake .. -G "Visual Studio 15 2017 Win64" -T > > "host=x64" -DENABLE_LIBEVENT=1 -DHAS_AUTHENTICATION=0 > > -- The C compiler identification is MSVC 19.10.25017.0 > > -- The CXX compiler identification is MSVC 19.10.25017.0 > > -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual > > Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe > > -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual > > Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- > > works > > -- Detecting C compiler ABI info > > -- Detecting C compiler ABI info - done > > -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual > > Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe > > -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual > > Studio/2017/BuildTools/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- > > works > > -- Detecting CXX compiler ABI info > > -- Detecting CXX compiler ABI info - done > > -- Detecting CXX compile features > > -- Detecting CXX compile features - done > > -- cotire 1.7.9 loaded. > > -- ************************************************************ > > -- ********* Beginning Mesos CMake configuration step ********* > > -- ************************************************************ > > -- INSTALLATION PREFIX: C:/Program Files/Mesos > > -- MACHINE SPECS: > > -- Hostname: > > -- OS: WINDOWS(10.0.14393) > > -- Arch: AMD64 > > -- BitMode: > > -- BuildID: > > -- ************************************************************ > > -- Performing Test COMPILER_SUPPORTS_CXX11 > > -- Performing Test COMPILER_SUPPORTS_CXX11 - Success > > -- GnuWin32 patch.exe exists at: C:/Program Files > > (x86)/GnuWin32/bin/patch.exe > > -- Looking for pthread.h > > -- Looking for pthread.h - not found > > -- Found Threads: TRUE > > -- CXX target mesos-1.4.0 cotired. > > -- Configuring done > > -- Generating done > > -- Build files have been written to: C:/Users/mesos/mesos/build > > > > C:\Users\mesos\mesos\build>if 1 NEQ 0 exit /b 1 > > > > Full log: NotAvailableYet\console
Ignore this; it built and linked on my machine. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59470/#review175730 ----------------------------------------------------------- On May 22, 2017, 11:32 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59470/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 11:32 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-7545 > https://issues.apache.org/jira/browse/MESOS-7545 > > > Repository: mesos > > > Description > ------- > > The environment secret resolver isolator was previously enabled for all > builds, but the isolator source was not included in the windows build > and caused build failure. > > > Diffs > ----- > > src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 > > > Diff: https://reviews.apache.org/r/59470/diff/1/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
