----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59506/#review175886 -----------------------------------------------------------
Fix it, then Ship it! src/slave/main.cpp Line 287 (original), 286 (patched) <https://reviews.apache.org/r/59506/#comment249231> Not yours but the trailing period is inconsistent with our convention. Remove it? src/slave/main.cpp Line 293 (original), 291 (patched) <https://reviews.apache.org/r/59506/#comment249232> Ditto. - Jiang Yan Xu On May 23, 2017, 3:28 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59506/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 3:28 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-7549 > https://issues.apache.org/jira/browse/MESOS-7549 > > > Repository: mesos > > > Description > ------- > > Consistently use EXIT() in agent startup. > > > Diffs > ----- > > src/slave/main.cpp 47b5576f2688de39d307b25e5f7f4140b230b522 > > > Diff: https://reviews.apache.org/r/59506/diff/2/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
