----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59484/#review175906 -----------------------------------------------------------
src/master/allocator/sorter/drf/sorter.cpp Lines 102-108 (original), 102 (patched) <https://reviews.apache.org/r/59484/#comment249253> Did we lose the `!= lastCreatedNode` check here? or am I missing something? src/master/allocator/sorter/drf/sorter.cpp Lines 125-127 (original), 119-122 (patched) <https://reviews.apache.org/r/59484/#comment249252> Is this reordering meaningful? - Michael Park On May 22, 2017, 11:28 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59484/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 11:28 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, Michael Park, and > Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > This helps clarify code that wants to distinguish between leaves and > internal nodes in the sorter. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > fee58d6d1f08163e2a06a4a20c891fe535c3dcff > src/master/allocator/sorter/drf/sorter.cpp > 26b77f578f3235a8792c72d4575d607cdb2c7de7 > > > Diff: https://reviews.apache.org/r/59484/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
