----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53666/#review176028 -----------------------------------------------------------
Patch looks great! Reviews applied: [53666] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 24, 2017, 5:46 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53666/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 5:46 p.m.) > > > Review request for mesos, Jie Yu, James Peach, and Jiang Yan Xu. > > > Bugs: MESOS-6489 > https://issues.apache.org/jira/browse/MESOS-6489 > > > Repository: mesos > > > Description > ------- > > Added a `continueOnError` attribute to cgroups `Destroyer` to allow > cgroups cleanup to continue incase of any error. The linux launcher > continues cleanup of cgroups even if there is an error. However, if > the top level cgroup is actually removed, it treats it as a success. > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > src/slave/containerizer/mesos/linux_launcher.cpp > 1cea04edac8e0c4aea8c1c7d946b5065f3eac931 > > > Diff: https://reviews.apache.org/r/53666/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
