----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/#review176080 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 7077 (patched) <https://reviews.apache.org/r/59545/#comment249408> You need to wait until the acknowledgement is checkpointed by the agent to ensure agent doesnt retry after a restart. src/tests/slave_tests.cpp Lines 7136 (patched) <https://reviews.apache.org/r/59545/#comment249409> what's the guarantee that master finished processing the reregisterslave message? need a clock settle? - Vinod Kone On May 24, 2017, 11:10 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59545/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 11:10 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-7540 > https://issues.apache.org/jira/browse/MESOS-7540 > > > Repository: mesos > > > Description > ------- > > This patch adds a test to verify the correct behavior of > the agent flag 'executor_reregistration_timeout. > > > Diffs > ----- > > src/tests/slave_tests.cpp d124d594fb4f20db3f5dacbc7482d97161cca2df > > > Diff: https://reviews.apache.org/r/59545/diff/1/ > > > Testing > ------- > > `bin/mesos-tests.sh --gtest_filter="*ExecutorReregistrationTimeoutFlag*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
