-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59537/#review176153
-----------------------------------------------------------
Bad patch!
Reviews applied: [59537]
Failed command: python support/apply-reviews.py -n -r 59537
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 381, in <module>
reviewboard()
File "support/apply-reviews.py", line 360, in reviewboard
apply_review()
File "support/apply-reviews.py", line 126, in apply_review
commit_patch()
File "support/apply-reviews.py", line 225, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 111, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position
25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/../logs/console
- Mesos Reviewbot Windows
On May 25, 2017, 4:33 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59537/
> -----------------------------------------------------------
>
> (Updated May 25, 2017, 4:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod
> Kone.
>
>
> Bugs: MESOS-7546
> https://issues.apache.org/jira/browse/MESOS-7546
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in the Composing Containerizer that would make it always
> immediately return 'None' when trying to wait on a nested container
> that had already been terminated and whose exit status was checkpointed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.cpp
> 0b6c76b3d081d86df81a6062ae7a191ba8dadfde
>
>
> Diff: https://reviews.apache.org/r/59537/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux, plus manual testing using an agent that uses both
> the Docker and the Mesos containerizers.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
