----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/#review176154 -----------------------------------------------------------
src/tests/master_tests.cpp Lines 5635-5636 (patched) <https://reviews.apache.org/r/59578/#comment249510> Is this something standard we've been doing recently to fix flaky tests? I'm not familiar with this pattern. of pausing the clocl and then advancing it manually. - Kevin Klues On May 25, 2017, 6:44 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59578/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 6:44 p.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Rather than depending on batch allocations to eventually occur, pause > the clock and explicitly advance it when we want to trigger a batch > allocation. This improves both test robustness and speed. > > > Diffs > ----- > > src/tests/master_tests.cpp 1dfe5fd7c33c3c479175aa522fef1956f11f265c > > > Diff: https://reviews.apache.org/r/59578/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
