----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review176162 -----------------------------------------------------------
Patch looks great! Reviews applied: [59454, 59413] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On May 25, 2017, 6:13 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59413/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 6:13 p.m.) > > > Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and > Neil Conway. > > > Bugs: MESOS-7520 > https://issues.apache.org/jira/browse/MESOS-7520 > > > Repository: mesos > > > Description > ------- > > Many of the `constexpr` variables fail to compile with errors such as `error: > 'Megabytes(32).Megabytes::<anonymous>' is not a constant expression because > it refers to an incompletely initialized variable`. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80829 > > This patch changes around the `Bytes` class a bit by getting rid of the small > classes that extend `Bytes`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/bytes.hpp 98223db50 > > > Diff: https://reviews.apache.org/r/59413/diff/5/ > > > Testing > ------- > > `./bootstrap && mkdir build && cd build && ../configure --disable-python > --disable-java --disable-optimize --disable-hardening && make -j$(nproc) && > make check -j$(nproc)` > > > Thanks, > > Aaron Wood > >
