----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59596/#review176163 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/v1/resource_provider/resource_provider.hpp Line 17 (original), 17 (patched) <https://reviews.apache.org/r/59596/#comment249515> Should we also fix the ifdef guard in `include/mesos/resource_provider/resource_provider.hpp`? Also there are a couple more headers that also only include corresponding protobuf headers but not using this `_PROTO_` naming, such as `include/mesos/docker/v1.hpp`. They can be fixed later, just leave a note here. - Chun-Hung Hsiao On May 26, 2017, 1:01 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59596/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 1:01 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and > Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Renamed the ifdef guard for v1 resource provider header. > > > Diffs > ----- > > include/mesos/v1/resource_provider/resource_provider.hpp > 2b8c8afab852621fb49b132813d512d0c96bc68c > > > Diff: https://reviews.apache.org/r/59596/diff/1/ > > > Testing > ------- > > > Thanks, > > Jie Yu > >
