----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59628/#review176280 -----------------------------------------------------------
This file does not below in here. It is something that should be at the top level net to the main function, not part of the library. We will need to explicitly pass the settings into `Config()` at instantiation instead of importing them if we need access to them in there (which I think we do). - Kevin Klues On May 29, 2017, 3:27 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59628/ > ----------------------------------------------------------- > > (Updated May 29, 2017, 3:27 p.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > The file contains constants used by the CLI and upcoming tests. > > > Diffs > ----- > > src/cli_new/bin/main.py d0ec2bdb04631fbaa62efb6ae67e138140a1296a > src/cli_new/bin/settings.py > > > Diff: https://reviews.apache.org/r/59628/diff/1/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
