> On May 30, 2017, 1:55 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 168 (patched) > > <https://reviews.apache.org/r/59254/diff/3/?file=1734798#file1734798line168> > > > > Can you use a PID rather than a UPID?
Sure. FWIW I copied it from https://github.com/apache/mesos/blob/55e7ea5ed788acb0e4f810dd4575a5a4479520d1/src/authentication/http/combined_authenticator.cpp#L275 > On May 30, 2017, 1:55 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 176 (patched) > > <https://reviews.apache.org/r/59254/diff/3/?file=1734798#file1734798line176> > > > > Did you need the explicit return type of the lambda? I tried not to use it but failed. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59254/#review176348 ----------------------------------------------------------- On May 30, 2017, 11:12 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59254/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 11:12 a.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Michael Park. > > > Repository: mesos > > > Description > ------- > > This also gets rid of the old "batch" (interval-based) allocation concept > because we now > use the term to describe the grouping of all pending allocation candidates in > an allocation run. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 123f97cf495bff0f822838e09df0d88818f04da6 > src/master/allocator/mesos/hierarchical.cpp > 5511bf6ce8c866c8a8436595f5b3eb1ef81c999f > > > Diff: https://reviews.apache.org/r/59254/diff/3/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
