----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/#review176402 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Lines 991 (patched) <https://reviews.apache.org/r/59463/#comment249767> you need to wait until the ack is checkpointed. - Vinod Kone On May 30, 2017, 11:29 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59463/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 11:29 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-7540 > https://issues.apache.org/jira/browse/MESOS-7540 > > > Repository: mesos > > > Description > ------- > > This patch adds a new test, > `SlaveRecoveryTest.PingTimeoutDuringRecovery`, which verifies > that the agent will reply to pings from the master while it > is performing recovery. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp df0c5c88786190be06df7ef3602834aa8985cefe > > > Diff: https://reviews.apache.org/r/59463/diff/6/ > > > Testing > ------- > > `GTEST_FILTER="*PingTimeoutDuringRecovery*" bin/mesos-tests.sh > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
