----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58955/#review176636 -----------------------------------------------------------
src/tests/api_tests.cpp Lines 766 (patched) <https://reviews.apache.org/r/58955/#comment250006> +1 src/tests/api_tests.cpp Lines 770 (patched) <https://reviews.apache.org/r/58955/#comment250010> This is why we have added the `AWAIT_EXPECT_RESPONSE_STATUS_EQ` macro. Let's please use that instead, makes the code a lot slicker. Future<http::Response> response = http::post( master.get()->pid, "api/v1", headers, serialize(contentType, v1Call), stringify(contentType)); AWAIT_EXPECT_RESPONSE_STATUS_EQ(http::Forbidden().status, response); There are already a couple of places outside these new additions using that unfortunate pattern - could you please clean those up in a follow up? - Till Toenshoff On May 22, 2017, 3:57 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58955/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 3:57 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7414 > https://issues.apache.org/jira/browse/MESOS-7414 > > > Repository: mesos > > > Description > ------- > > Enables authorization in the v1 API call `SET_LOGGING_LEVEL` following > the existing implementation for the agent call with the same name. > Likewise it reuses the authorizer action `SET_LOG_LEVEL`. > > > Diffs > ----- > > src/master/http.cpp 7060b8fa53e0682681c50e051908ffbbf50fb7da > src/tests/api_tests.cpp faf3242f9c86d866c4bb5e457fcfe47c1063cc09 > > > Diff: https://reviews.apache.org/r/58955/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
