-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59605/
-----------------------------------------------------------
(Updated June 2, 2017, 11:53 a.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin
Mahler, and Till Toenshoff.
Summary (updated)
-----------------
Used glog for logging in executors.
Bugs: MESOS-6961
https://issues.apache.org/jira/browse/MESOS-6961
Repository: mesos
Description (updated)
-------
The rule for choosing between glog and cout is described by MESOS-7586.
Diffs (updated)
-----
src/docker/executor.cpp 464a74859e0f477ec2e5525a5fc726ea420a00a2
src/launcher/default_executor.cpp 1a60e3bb2b0e8312b349cddedb4cd55716c1b574
src/launcher/executor.cpp 9ac3c3d84c0ec47954c5c72228ad0b8795ff3eec
Diff: https://reviews.apache.org/r/59605/diff/2/
Changes: https://reviews.apache.org/r/59605/diff/1-2/
Testing
-------
1. make check (mac os x 10.12, fedora 25)
2. jenkins:
https://jenkins.mesosphere.com/service/jenkins/job/mesos/job/Mesos_CI-build/1087/
3. I've modified NoTaskKillingCapability from command_executor_tests.cpp to
launch command "sleep 0.1" (as well as "sleep 0"),
then to wait for a task completion. The test was launched in an endless loop:
GLOG_v=1 ./bin/mesos-tests.sh --gtest_repeat=-1 --gtest_break_on_failure
--gtest_filter="HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0"
--verbose
I've run this test multiple times for a while both on mac os and linux
(gru1.hw.ca1.mesosphere.com).
Race condition problem described in a jira ticket wasn't reproduced.
Thanks,
Andrei Budnik
