----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59598/#review176760 -----------------------------------------------------------
src/resource_provider/storage/provider.cpp Lines 108 (patched) <https://reviews.apache.org/r/59598/#comment250230> The `SUBSCRIBED` call will also provide a `ResourceProviderID` assigned by the master. This should be handled here. src/resource_provider/storage/provider.cpp Lines 131 (patched) <https://reviews.apache.org/r/59598/#comment250231> Can you add a `TODO` here, so that it's clear that this function isn't intented to be empty and will be implemented later? - Jan Schlicht On May 26, 2017, 3:09 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59598/ > ----------------------------------------------------------- > > (Updated May 26, 2017, 3:09 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and > Jan Schlicht. > > > Bugs: MESOS-7570 > https://issues.apache.org/jira/browse/MESOS-7570 > > > Repository: mesos > > > Description > ------- > > Added registration logic to storage local resource provider. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/59598/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
