----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59200/#review176651 -----------------------------------------------------------
I can fix the following small things up before committing. 3rdparty/stout/include/stout/posix/net.hpp Lines 31 (patched) <https://reviews.apache.org/r/59200/#comment250052> Hm, we don't need this guard anymore. The only other system that might not have this implemented is `__sun`, but I have not heard of anyone building Mesos on Solaris in a while (fairly certain we don't support that anymore). 3rdparty/stout/include/stout/windows/net.hpp Lines 27-30 (patched) <https://reviews.apache.org/r/59200/#comment250061> Mesos requires 64 bit, so this part isn't necessary. 3rdparty/stout/include/stout/windows/net.hpp Lines 63-71 (patched) <https://reviews.apache.org/r/59200/#comment250151> As we discussed offline, there's no particular reason to use a human-readable MAC address vs. the adaptor name. We'll use the adaptor name unless there's a good reason to do the extra stringification. - Joseph Wu On May 11, 2017, 1:56 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59200/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 1:56 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-5938 > https://issues.apache.org/jira/browse/MESOS-5938 > > > Repository: mesos > > > Description > ------- > > Note that, rather than returning an interface name, the Windows > version will return the MAC address. The actual interface name, > on Windows, is a GUID (since there can be multiple wireless > interfaces, for example). However, it's not possible to get the > GUID from the command line (via 'ipconfig'). > > As a result, the MAC address of the interface (also unique) is > used to uniquely identify a particular interface on the system. > > > Diffs > ----- > > 3rdparty/stout/include/stout/net.hpp > b7cef53d3df8688f88211d7107927b7c8ccaed7f > 3rdparty/stout/include/stout/posix/net.hpp > 39b89828d350d83bf1d4b0badcd3e63eb9d1a630 > 3rdparty/stout/include/stout/windows/net.hpp > 1bed115cb848332bf9c31e455b2d001c173face9 > > > Diff: https://reviews.apache.org/r/59200/diff/2/ > > > Testing > ------- > > See final commit for tests performed. > > > Thanks, > > Jeff Coffler > >
