----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59829/#review177003 -----------------------------------------------------------
Patch looks great! Reviews applied: [59829] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 6, 2017, 7:41 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59829/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 7:41 a.m.) > > > Review request for mesos, Michael Park and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Our C++ style guide is based on the Google C++ style guide which > already gives rather detailed recommendations[^1], e.g., on how to > capture. In particular, it recommends capture by value and goes into > some detail on the caveats of capturing pointer values. > > Our customization on top of the Google style guide does not add much, > but while pointing out the issues of capturing by reference, misses > that pointers captured by value bring about similar issues. > > [^1]: > https://google.github.io/styleguide/cppguide.html#Lambda_expressions > > > Diffs > ----- > > docs/c++-style-guide.md 1fec9a76ce3c7193c75ff0ec226ff91cdb2adf79 > > > Diff: https://reviews.apache.org/r/59829/diff/1/ > > > Testing > ------- > > Examined rendered site. > > > Thanks, > > Benjamin Bannier > >
