----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59841/#review177046 -----------------------------------------------------------
Patch looks great! Reviews applied: [59841] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 6, 2017, 3:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59841/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 3:48 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > By 'dispatch'ing to a PID the lines touched here already carefully > avoided calling member functions of a destructed object. This change > tidyies up the code to directly pass in the address of the member > function to call instead of constructing a lambda capturing around the > invocation which needs to capture 'this'. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 1868adf292615a89eddfb8903de5af9efbc0c496 > > > Diff: https://reviews.apache.org/r/59841/diff/1/ > > > Testing > ------- > > make check (Fedora 25, clang-trunk w/ optimizations) > > > Thanks, > > Benjamin Bannier > >
