----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59858/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- A `Deferred` function object is always defined to be a `std::function`, so when we are constructing a `Gauge` metrics is it not strictly required for the callback to be a `Deferred` object. In cases where the value is a constant or can be calculated by reading constant data, a metrics producer can emit a `Gauge` without the taking th additional dispatch cost. Diffs ----- 3rdparty/libprocess/include/process/metrics/gauge.hpp c5bbeaf5d53c60f3636d1778db47cdb6cdda34e8 3rdparty/libprocess/src/tests/metrics_tests.cpp c13520d23ca17144f553fb4588fb8a747ea46e72 Diff: https://reviews.apache.org/r/59858/diff/1/ Testing ------- make check (Fedora 25) Thanks, James Peach
