> On June 6, 2017, 11:04 p.m., Joseph Wu wrote: > > The ASF CI uses this hack to convert these: > > ``` > > --verbose --enable-libevent --enable-ssl > > --verbose > > ``` > > To: > > ``` > > -DVERBOSE=1 -DENABLE_LIBEVENT=1 -DENABLE_SSL=1 > > -DVERBOSE=1 > > ``` > > > > The optimize and debug options were never used in this CI at least.
Ah, you'd actually be okay without this change for now then. Though I hate to rely on a mapping like that. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59774/#review177115 ----------------------------------------------------------- On June 3, 2017, 7:27 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59774/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 7:27 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > While convenient, this mapping was forcing the CMake build to be setup > exactly like the Autotools build, even when it was antithetical to a > proper CMake build system. > > Instead, the `docker-build.sh` script now expects a CMake configuration > when the CMake build tool is specified. > > > Diffs > ----- > > support/docker-build.sh d17cc765a11097227f25b1897f61676677f83b87 > > > Diff: https://reviews.apache.org/r/59774/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
