----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59773/#review177124 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On June 3, 2017, 12:26 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59773/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 12:26 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > This option was added as a mapping from the Autotools `--enable-debug` > flag. However, it does not work as expected, since some CMake generators > are multi-configuration. That is, CMake does not necessarily configure a > particular Debug or Release configuration, and instead (for some > generators, such as Visual Studio) it produces build files where the > congfiguration can be changed at build time. > > The CMake documentation states that the variable `CMAKE_BUILD_TYPE` > should never be set in a CMake file (although it can be referenced, as > CMake is automatically invoked during builds, where it may be defined). > Thus multi-configuration generators did not respect what a user intended > with `-DENABLE_DEBUG=1` nor with `-DENABLE_DEBUG=0`, and the default > configuration was meaningless. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 > > > Diff: https://reviews.apache.org/r/59773/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
