----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59772/#review177119 -----------------------------------------------------------
Ship it! I'm going to mention (in the commit message) that the two configs can be toggled via: `cmake --build . --config [Debug|Release]` (for multi-configuration build systems) and via `-DCMAKE_BUILD_TYPE=[Debug|Release]` for other build generators. - Joseph Wu On June 3, 2017, 12:26 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59772/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 12:26 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > This option was added as a mapping from the Autotools > `--enable-optimize` flag. However, it does not work as expected, since > CMake automatically adds platform-specific optimization flags depending > on the build configuration. That is, Debug builds are not optimized, and > Release builds are optimized. Therefore, all this option did was to > unnecessarily add optimizations to the Debug build, and fail to disable > optimizations for the Release build. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 > > > Diff: https://reviews.apache.org/r/59772/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
