> On June 5, 2017, 8:30 p.m., Benjamin Mahler wrote: > > src/webui/master/static/framework.html > > Lines 53-54 (patched) > > <https://reviews.apache.org/r/59796/diff/1/?file=1741037#file1741037line61> > > > > What this currently shows is Used (allocated) and Allocated > > (allocated+offered): > > > > > > https://github.com/apache/mesos/blob/1.3.0-rc3/src/master/http.cpp#L236-L240 > > https://github.com/apache/mesos/blob/1.3.0-rc3/src/master/http.cpp#L424 > > > > So this is a bit confusing, since I think people generally think of > > offered as not being allocated yet. > > > > How about instead showing these two columns: Allocated and Offered.
thx @bmahler, have fixed. May you help to review again? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59796/#review176947 ----------------------------------------------------------- On June 7, 2017, 2:30 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59796/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 2:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Tomasz Janiszewski, Neil Fordyce, > and Vinod Kone. > > > Bugs: MESOS-7458 > https://issues.apache.org/jira/browse/MESOS-7458 > > > Repository: mesos > > > Description > ------- > > Show used resources in per-framework page. > > > Diffs > ----- > > src/webui/master/static/framework.html > ee683bc22354b1726abe256ca991df2d7c67faeb > > > Diff: https://reviews.apache.org/r/59796/diff/2/ > > > Testing > ------- > > see screenhost in attached file. > > > File Attachments > ---------------- > > screenshot.png > > https://reviews.apache.org/media/uploaded/files/2017/06/05/240a56ea-dd0d-49c2-a683-6a0ffe08f7a6__screenshot.png > screenshot_1.png > > https://reviews.apache.org/media/uploaded/files/2017/06/07/17460501-4b6e-4b02-9f52-6165d58cf83f__screenshot_1.png > > > Thanks, > > haosdent huang > >
