----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59882/#review177171 -----------------------------------------------------------
Patch looks great! Reviews applied: [59882] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 7, 2017, 2:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59882/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 2:52 p.m.) > > > Review request for mesos, Jie Yu and Neil Conway. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp 6f963d4aa58cf4e5b5cb8bed0be314c806eac1d7 > src/tests/resources_tests.cpp eb8b551dab6313451a7cbe02af0c348f5a95ee3d > > > Diff: https://reviews.apache.org/r/59882/diff/1/ > > > Testing > ------- > > `make check` > > I also compared `Resources`-related benchmarks before and after applying this > fix. No clear movement was visible in the timings beyond noise. > > > Thanks, > > Benjamin Bannier > >
