----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59892/#review177219 -----------------------------------------------------------
src/tests/slave_tests.cpp Line 7221 (original), 7221 (patched) <https://reviews.apache.org/r/59892/#comment250764> Nit: can we remove this newline? src/tests/slave_tests.cpp Lines 7236 (patched) <https://reviews.apache.org/r/59892/#comment250762> The `FUTURE_PROTOBUF` needs to be set before `StartSlave` is called; otherwise there's a race. src/tests/slave_tests.cpp Lines 7372 (patched) <https://reviews.apache.org/r/59892/#comment250763> Ibid. - Neil Conway On June 7, 2017, 8:23 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59892/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 8:23 p.m.) > > > Review request for mesos, Neil Conway and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This patch addresses some style issues in two agent tests, > `SlaveTest.DisconnectedExecutorDropsMessages` and > `SlaveTest.ExecutorReregistrationTimeoutFlag`. > > > Diffs > ----- > > src/tests/slave_tests.cpp b5141d7013acdd6e236606ef3d9b1953b14d373a > > > Diff: https://reviews.apache.org/r/59892/diff/1/ > > > Testing > ------- > > `bin/mesos-tests.sh > --gtest_filter="*DisconnectedExecutorDropsMessages*:*ExecutorReregistrationTimeoutFlag*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >
