> On June 7, 2017, 4:49 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.hpp > > Lines 58 (patched) > > <https://reviews.apache.org/r/59874/diff/1/?file=1743744#file1743744line58> > > > > I'd rather keep `id` (or `name`) in each class and pass it down to > > `CheckerProcess`.
I don't think we need to keep `name` in each class, but I did update the patch to generate it there and pass it down, instead of generating it in `CheckerProcess`. > On June 7, 2017, 4:49 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.hpp > > Lines 140 (patched) > > <https://reviews.apache.org/r/59874/diff/1/?file=1743744#file1743744line140> > > > > If you inherited `id` (`name`), you could update it here instead of > > having a separate `buildName` function for this and an extra `description` > > field. I'm saving the name in a different field and not using it as the process ID, because Process IDs are separated by dashes instead of spaces, and that would look pretty bad in the log messages. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59874/#review177180 ----------------------------------------------------------- On June 8, 2017, 12:26 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59874/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 12:26 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-7092 > https://issues.apache.org/jira/browse/MESOS-7092 > > > Repository: mesos > > > Description > ------- > > Made `CheckerProcess` use a consistent description for log messages. > > > Diffs > ----- > > src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 > src/checks/checker_process.hpp PRE-CREATION > src/checks/checker_process.cpp PRE-CREATION > src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 > > > Diff: https://reviews.apache.org/r/59874/diff/2/ > > > Testing > ------- > > Tests still pass on GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
