----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59899/#review177319 -----------------------------------------------------------
Fix it, then Ship it! LGTM module minor nits. src/tests/containerizer/docker_containerizer_tests.cpp Lines 4204-4208 (patched) <https://reviews.apache.org/r/59899/#comment250846> Why the split? Why not: Shared<Docker> docker(new MockDocker(tests::flags.docker, tests::flags.docker_socket)); src/tests/containerizer/docker_containerizer_tests.cpp Lines 4216 (patched) <https://reviews.apache.org/r/59899/#comment250847> Kill newline here or add one after `slave` for consistency? src/tests/containerizer/docker_containerizer_tests.cpp Lines 4271 (patched) <https://reviews.apache.org/r/59899/#comment250850> Should we check `stdout` contents as well. Something like `echo test && sleep 1000`? - Kapil Arya On June 7, 2017, 7:07 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59899/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 7:07 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This test would fail before applying the Docker containerizer sandbox > stdout/stderr ownership fix. Note that when we are setting a task-user, > this test did not fail before - only when setting the framework-user > but not the task-user. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 84e062a03c8c13bab5739e44031c91379362d417 > > > Diff: https://reviews.apache.org/r/59899/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
