> On June 8, 2017, 9:53 p.m., Joseph Wu wrote: > > cmake/MesosConfigure.cmake > > Line 60 (original), 60 (patched) > > <https://reviews.apache.org/r/59786/diff/1/?file=1741011#file1741011line60> > > > > The `${}` here is extraneous.
Yes, and should be removed as it can cause unexpected? behavior. Good catch. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59786/#review177390 ----------------------------------------------------------- On June 3, 2017, 7:33 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59786/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 7:33 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-5994 and MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-5994 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > Instead of hard-coding this based on the platform, this sets it based on > the canonical `BUILD_SHARED_LIBS` option. When not set, the default > linkage is platform-specific. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake a0032a35d5c02cc6e7a5e90c187dae4954879f95 > cmake/MesosConfigure.cmake e44f662b6da71caa493cc568a5e5bcb0a608a8b1 > > > Diff: https://reviews.apache.org/r/59786/diff/1/ > > > Testing > ------- > > Note that building with shared libraries on Windows is not quite supported > yet; this (and the rest of the series) just gets us a lot closer. > > > Thanks, > > Andrew Schwartzmeyer > >
