> On June 8, 2017, 9:20 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > > Lines 115-116 (patched) > > <https://reviews.apache.org/r/59779/diff/1/?file=1741002#file1741002line116> > > > > Is there any reason why this isn't done in one line? > > > > i.e. `libprotobuf$<$<CONFIG:Debug>:d>`
It was kind of ugly. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59779/#review177369 ----------------------------------------------------------- On June 3, 2017, 7:32 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59779/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 7:32 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-6814 and MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-6814 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > Fixed the configuration-dependent protobuf linkage. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > 83406f271b52655fbda241f15d99a2c8268362f8 > > > Diff: https://reviews.apache.org/r/59779/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
