----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59891/#review177397 -----------------------------------------------------------
Patch looks great! Reviews applied: [59891] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 7, 2017, 12:50 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59891/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 12:50 p.m.) > > > Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li. > > > Bugs: MESOS-7638 > https://issues.apache.org/jira/browse/MESOS-7638 > > > Repository: mesos > > > Description > ------- > > This fixes tests that pass but emit error messages due to `false` not > existing as a command on Windows. > > > Diffs > ----- > > src/tests/health_check_tests.cpp 7917a222daf6a8fbe2a5fe6657852e6ff6e699ba > > > Diff: https://reviews.apache.org/r/59891/diff/2/ > > > Testing > ------- > > Trying to split out fixes I made in my fix-long-paths branch that can be > applied sooner, so this has been tested quite thoroughly but with other > patches. > > > Thanks, > > Andrew Schwartzmeyer > >
