> On June 8, 2017, 7:25 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt > > Lines 75-86 (patched) > > <https://reviews.apache.org/r/59776/diff/1/?file=1740998#file1740998line75> > > > > Hum. I'm going to take some liberties with this comment :) > > > > * Going to move this comment above the `list(APPEND CMAKE_FORWARD_ARGS` > > and merge it with the comment there. > > * Instead of mentioning `CMAKE_NOOP`, might be better to just note when > > `CMAKE_ARGS` will be ignored. > > * The note about `SUB_DIR` seems out of place.
Also, per `CMAKE_NOOP` I propose to you we delete `Common.cmake` and just define `CMAKE_NOOP` here. It's the only thing in `Common.cmake` but should live closer to its only uses. Agreed on the note about `SOURCE_SUBDIRR`, just need to keep it somewhere. Related note: you'll notice a pair of dependencies that are `if/else` since `SOURCE_SUBDIR` isn't supported until CMake 3.7, which should be noted too. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59776/#review177353 ----------------------------------------------------------- On June 3, 2017, 7:31 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59776/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 7:31 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > This commit also forwards the arguments to the projects where no other > changes need to be made. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f > > > Diff: https://reviews.apache.org/r/59776/diff/1/ > > > Testing > ------- > > This will require finally resolving > https://issues.apache.org/jira/browse/MESOS-6350 unless we want to rewrite > some logic. > > > Thanks, > > Andrew Schwartzmeyer > >
