> On June 8, 2017, 8:14 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt > > Lines 360 (patched) > > <https://reviews.apache.org/r/59778/diff/1/?file=1741001#file1741001line370> > > > > Hm. Surprised we didn't notice this `src/..` part of the path to the > > configure script. I'll get rid of it before committing.
I'm surprised too. Also: if we _did_ update minimum required CMake to 3.7 on Linux... we can get rid of the Autotools logic and use CMake entirely for Protobuf. Just a thought! - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59778/#review177252 ----------------------------------------------------------- On June 3, 2017, 7:32 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59778/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 7:32 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-6814 and MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-6814 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > This also replaces the hard-coded configuration and build steps for > protobuf on Windows, with the default CMake driven process from > `ExternalProject_Add`, using `SOURCE_SUBDIR cmake`. Unfortunately, the > call to `ExternalProject_Add` must be duplicated because older versions > of CMake don't support `SOURCE_SUBDIR`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f > > > Diff: https://reviews.apache.org/r/59778/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
