> On June 8, 2017, 2:20 p.m., Joseph Wu wrote: > > 3rdparty/CMakeLists.txt > > Lines 173-178 (original), 172-177 (patched) > > <https://reviews.apache.org/r/59780/diff/1/?file=1741003#file1741003line175> > > > > We should be able to delete this line now that we have: > > `-DEVENT__BUILD_SHARED_LIBRARIES=${BUILD_SHARED_LIBS}` > > Andrew Schwartzmeyer wrote: > Will need to double-check the libevent build system... I vaguely recall > needing to explicitly add `-fPIC` somewhere.
If we keep this here, there will be two instances of `-DCMAKE_C_FLAGS` in the `CMAKE_ARGS`. --- While we're at it, we should consider bumping from 2.1.5-beta to 2.1.8-stable: https://github.com/libevent/libevent/releases/tag/release-2.1.8-stable - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59780/#review177372 ----------------------------------------------------------- On June 3, 2017, 12:32 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59780/ > ----------------------------------------------------------- > > (Updated June 3, 2017, 12:32 p.m.) > > > Review request for mesos, Jeff Coffler, Joseph Wu, and Li Li. > > > Bugs: MESOS-6814 and MESOS-7618 > https://issues.apache.org/jira/browse/MESOS-6814 > https://issues.apache.org/jira/browse/MESOS-7618 > > > Repository: mesos > > > Description > ------- > > This removes the hard-coded `C_FLAGS` and properly forwards all > arguments for each configuration. This also disables building the > unnecessary benchmark, tests, and samples artifacts. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 96022ffaab94cfdfa3af0cadcfefc0c6518a6f6f > > > Diff: https://reviews.apache.org/r/59780/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
