----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59859/#review177527 -----------------------------------------------------------
Fix it, then Ship it! Modulo neil's comments, might be nice to have some more clarity in the comments about how hierarchical roles affected the agents (volumes paths?). include/mesos/mesos.proto Lines 811 (patched) <https://reviews.apache.org/r/59859/#comment251159> This isn't a consumable API so marking it as experimental seems odd? include/mesos/v1/mesos.proto Lines 805 (patched) <https://reviews.apache.org/r/59859/#comment251160> Ditto here - Benjamin Mahler On June 6, 2017, 9:53 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59859/ > ----------------------------------------------------------- > > (Updated June 6, 2017, 9:53 p.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7632 > https://issues.apache.org/jira/browse/MESOS-7632 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc > include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402 > src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 > src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d > src/slave/constants.cpp 0fbcab8f1cee4183dfd4c25984cd27f8baabda44 > src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 > src/tests/slave_tests.cpp b5141d7013acdd6e236606ef3d9b1953b14d373a > src/tests/upgrade_tests.cpp b07426fa1e402c88a8a647eafdb77f6ebadd9959 > > > Diff: https://reviews.apache.org/r/59859/diff/1/ > > > Testing > ------- > > Updated existing tests / `make check` > > > Thanks, > > Michael Park > >
