----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59993/#review177598 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On June 12, 2017, 9:42 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59993/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 9:42 a.m.) > > > Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > 'http_parser.h' defines a C-style enum 'flags' which clashes with e.g., > a namespace name in stout. In '7c6a750a85becabbaa5c118c3735020400f11c39' > we attempted to fix this by directly patching 'http_parser.h'. This fix > broken support for building with unbundled http_parser dependency. > > In this patch we remove the requirement to patch http_parser and instead > directly rename http_parser's 'flags' variable when the defining header > is included. This currently is just a single location. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > 31e8851d6882648937f3e0c37192131f8b057a89 > > > Diff: https://reviews.apache.org/r/59993/diff/1/ > > > Testing > ------- > > Tested on internal CI on various configurations. > > > Thanks, > > Benjamin Bannier > >
