----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/#review177627 -----------------------------------------------------------
3rdparty/stout/tests/protobuf_tests.cpp Lines 614 (patched) <https://reviews.apache.org/r/59989/#comment251321> Mind explaining how the magical numerical numbers are picked? 3rdparty/stout/tests/protobuf_tests.cpp Lines 636 (patched) <https://reviews.apache.org/r/59989/#comment251320> nit: add a comment to explain this is a base64 encoding? - Zhitao Li On June 12, 2017, 2:06 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59989/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 2:06 a.m.) > > > Review request for mesos, Anand Mazumdar and Zhitao Li. > > > Repository: mesos > > > Description > ------- > > Added a test `ProtobufTest.JsonifyMap`. > > > Diffs > ----- > > 3rdparty/stout/tests/protobuf_tests.cpp > 8877e8934e0f7875bfedcfa88b491ce4b13ca44f > > > Diff: https://reviews.apache.org/r/59989/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
