----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59101/#review177652 -----------------------------------------------------------
Ship it! lgtm src/master/http.cpp Lines 4696 (patched) <https://reviews.apache.org/r/59101/#comment251338> We might want to come up with a JIRA discussing and suggesting a solution for these filtering function failures. - Till Toenshoff On June 12, 2017, 2:37 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59101/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 2:37 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7415 > https://issues.apache.org/jira/browse/MESOS-7415 > > > Repository: mesos > > > Description > ------- > > Enables the use of authorization for the 'GET_MAINTENANCE_STATUS' v1 > API call, as well as to the 'maintenance/status' endpoint, using the > ACL 'GetMaintenanceStatus' and the action of the same name as the API > call. > > It also updates the ApiTests to take into account the authorization > case. > > > Diffs > ----- > > src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 > src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f > src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 > src/tests/master_maintenance_tests.cpp > 9edd74a876cd2933d5a5be590a7dd3d10bc54253 > > > Diff: https://reviews.apache.org/r/59101/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
